Here you removed the \ from the front of the close bracket. Is that accidentally or on purpose?

Regardless, the expression are equivalent. In python even the opening brace does not need to be escaped, unless it's umbiguous (e.g., looks like a range expression).

I see, but there are many other places (eg. here, here or here) where the syntax follows the "old" format. I think it would be nice if we used the same syntax (and personally I prefer the old way, that's much clearer).

In Python regular expressions, special characters that need to be escaped outside of character classes include: *, +, ?, {, (, ), ^, $, |, and \. Inside character classes, you need to escape ], -, ^, and \ if they are used in a way that could confuse the regex parser.

In any case, formatting should be consistent.

In any case, formatting should be consistent.

Yeah, this is what I noticed.

Function errmsgf() is undefined.

With a minimal modification we could make this tool more flexible, I mean if someone wants to avoid to use uv, then they can use native was.

diff --git a/src/crs_linter/cli.py b/src/crs_linter/cli.py
index 5469cf7..5580c21 100755
--- a/src/crs_linter/cli.py
+++ b/src/crs_linter/cli.py
@@ -10,8 +10,14 @@ import re
 from dulwich.contrib.release_robot import get_current_version, get_recent_tags
 from semver import Version
 
-from crs_linter.linter import Check
-from crs_linter.logger import Logger
+try:
+    from linter import Check
+except:
+    from crs_linter.linter import Check
+try:
+    from logger import Logger
+except:
+    from crs_linter.logger import Logger
 
 
 def remove_comments(data):

And anyone can run from that directory with command ./cli.py ...

I know what you mean. People will still need to install prerequisites, right?

How is people going to install requirements (we will provide the option, of course)? If you want to use native, you probably also want to use virtualenv, right?

If you want to use native, you probably also want to use virtualenv, right?

Yes, of course.

This argument isn't documented in README.md (even it's mandatory).

Edit: I meant the -d DIRECTORY

Good catch. Now being a tool that lives outside the coreruleset directory, it needs it to properly catch the git labels.

It might not be needed if we are passing the proper version 🤔